Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary shows #1139

Closed
wants to merge 1 commit into from
Closed

Remove unecessary shows #1139

wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Nov 8, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d30e841) 74.64% compared to head (b425617) 75.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
+ Coverage   74.64%   75.63%   +0.99%     
==========================================
  Files          27       35       +8     
  Lines        9245     9503     +258     
==========================================
+ Hits         6901     7188     +287     
+ Misses       2344     2315      -29     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these shows were here originally because at one point we failed to pass in the Julia object so we needed some use of them to validate

@vchuravy
Copy link
Member Author

vchuravy commented Nov 8, 2023

Sure, but right now they are just noise when you run the testsuite?

@wsmoses
Copy link
Member

wsmoses commented Nov 8, 2023

Could we print to like dev null or some other use that ensures the object is valid

@vchuravy vchuravy closed this Nov 8, 2023
@vchuravy vchuravy deleted the vc/cleanup branch November 8, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants