-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vc/fixup isapplicable use v2 #2158
Conversation
vchuravy
commented
Dec 2, 2024
- Use right caller for isapplicable usage
- use absint directly for applicable check
- fix nothing error
- fix return type
- Fix nmatches type mismatch
- forward sv and interp instead
- fixup! forward sv and interp instead
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
56e8d57
to
45d8c41
Compare
another excellent indicator here is that we've reduced the CI time from ~55 mins to ~45 minutes. Sadly not quite the ~30 mins I think we had before absint shenanigans [correctly tracking backedges] so maybe worth diving in after this too, but regardless a remarkable improvement. |
lgtm, but would you mind bumping the enzymecore/enzyme project.toml's |