Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vc/fixup isapplicable use v2 #2158

Merged
merged 8 commits into from
Dec 5, 2024
Merged

vc/fixup isapplicable use v2 #2158

merged 8 commits into from
Dec 5, 2024

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Dec 2, 2024

  • Use right caller for isapplicable usage
  • use absint directly for applicable check
  • fix nothing error
  • fix return type
  • Fix nmatches type mismatch
  • forward sv and interp instead
  • fixup! forward sv and interp instead

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Benchmark Results

main bf6c435... main/bf6c435f13ceb2...
basics/overhead 4.34 ± 0.01 ns 4.03 ± 0.01 ns 1.08
time_to_load 1.16 ± 0.036 s 1.16 ± 0.015 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@vchuravy vchuravy force-pushed the vc/fixup_isapplicable_use_v2 branch from 56e8d57 to 45d8c41 Compare December 4, 2024 13:08
@vchuravy vchuravy mentioned this pull request Dec 4, 2024
@wsmoses
Copy link
Member

wsmoses commented Dec 4, 2024

another excellent indicator here is that we've reduced the CI time from ~55 mins to ~45 minutes. Sadly not quite the ~30 mins I think we had before absint shenanigans [correctly tracking backedges] so maybe worth diving in after this too, but regardless a remarkable improvement.

@wsmoses
Copy link
Member

wsmoses commented Dec 4, 2024

lgtm, but would you mind bumping the enzymecore/enzyme project.toml's

@wsmoses wsmoses merged commit 6606cd9 into main Dec 5, 2024
16 of 30 checks passed
@wsmoses wsmoses deleted the vc/fixup_isapplicable_use_v2 branch December 5, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants