per-flag bandit action filters (FF-3734) #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
commented
Dec 18, 2024
Comment on lines
-10
to
-13
| exclude = [ | ||
| "fastly-edge-assignments", | ||
| ] | ||
|
|
There was a problem hiding this comment.
this code is completed deleted now - my IDE was complaining about it here
| flag_key; | ||
| "No actions provided for flag that requires them" | ||
| ); | ||
| return None; |
There was a problem hiding this comment.
The JS commons implementation of getAllBandits (https://github.com/Eppo-exp/js-sdk-common/pull/180/files) produces this outcome by iterating over the actions keys - if a flag key does not have an actions key then it will not receive a bandit evaluation. This achieves the same thing.
rasendubi
approved these changes
Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the
get_precomputed_configurationtakes a single input of actions for bandit evaluations. This is a global list that gets applied to all bandits.However since we are evaluating all bandits together, each bandit has unique requirements for actions.
Description
Changing the function signature to accept a nested map of per-flag actions. The implementation looks for actions matching the bandit flag being evaluated.
Please see the expanded unit test for verification of functionality.
The implementation should conceptually match (Eppo-exp/js-sdk-common#180). That one iterates over the
actionsmap, while this implementation iterates over the available flags in the configuration. We should consider whether they produce the same result.Deploy plan
Publish these changes as
eppo_core@5.1.0and integrate into the edge assignment function. This will be the cut of functionality that will go out to support flag assignment in our internal service.