Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Evaluation Details #97

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat: Evaluation Details #97

merged 2 commits into from
Jul 11, 2024

Conversation

greghuels
Copy link
Contributor

@greghuels greghuels commented Jun 20, 2024

Evaluation Reasons - js-client-sdk-common
Evaluation Reasons - js-client-sdk
Evaluation Reasons - node-server-sdk
Evaluation Reasons - react-native-sdk

This is the main branch for the "Evaluation Reasons" work. Other PRs related to this feature will be merged into this branch before this branch is merged into main. This will not be mergeable until other work has been merged into this branch.

Implements: FF-2465

Motivation and Context

See Design Doc

Testing

This was manually tested locally with the js-node-sdk as well as with unit tests

@greghuels greghuels added the enhancement New feature or request label Jun 20, 2024
@greghuels greghuels force-pushed the greg/FF-2465/evaluation-reasons branch from b8377ac to ab97ac8 Compare June 21, 2024 12:18
@greghuels greghuels force-pushed the greg/FF-2465/evaluation-reasons branch 2 times, most recently from a7dfb70 to 33fc30b Compare July 2, 2024 13:06
@greghuels greghuels force-pushed the greg/FF-2465/evaluation-reasons branch from b849c6e to 2400ecf Compare July 8, 2024 12:55
@greghuels greghuels changed the title FF-2465 "Evaluation Reasons" feature feat: New "Details" assignment functions Jul 8, 2024
@greghuels greghuels force-pushed the greg/FF-2465/evaluation-reasons branch 2 times, most recently from e08c6c6 to bff5d50 Compare July 9, 2024 12:19
@greghuels greghuels force-pushed the greg/FF-2465/evaluation-reasons branch from 39ca994 to e8720f1 Compare July 11, 2024 10:15
@greghuels greghuels changed the title feat: New "Details" assignment functions feat: Evaluation Details Jul 11, 2024
@greghuels greghuels requested a review from rasendubi July 11, 2024 12:16
Copy link
Collaborator

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have missed changes to IFlagEvaluationDetails (thumbed up but didn't change the code) but otherwise looks good.

@greghuels
Copy link
Contributor Author

You seem to have missed changes to IFlagEvaluationDetails (thumbed up but didn't change the code) but otherwise looks good.

That's because those fields on IFlagEvaluationDetails get populated from an instance of the ConfigDetails interface, which requires non-null types. Default values are set in the getConfigDetails() function in eppo-client.ts. Other instances were updated though.

@@ -9,6 +9,7 @@
"outDir": "dist",
"noImplicitAny": true,
"strictNullChecks": true,
"strictPropertyInitialization": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/cache/lru-cache.ts Show resolved Hide resolved
@greghuels greghuels merged commit bfd89d1 into main Jul 11, 2024
2 checks passed
@greghuels greghuels deleted the greg/FF-2465/evaluation-reasons branch July 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants