-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Evaluation Details #97
Conversation
b8377ac
to
ab97ac8
Compare
a7dfb70
to
33fc30b
Compare
b849c6e
to
2400ecf
Compare
e08c6c6
to
bff5d50
Compare
39ca994
to
e8720f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have missed changes to IFlagEvaluationDetails
(thumbed up but didn't change the code) but otherwise looks good.
That's because those fields on |
@@ -9,6 +9,7 @@ | |||
"outDir": "dist", | |||
"noImplicitAny": true, | |||
"strictNullChecks": true, | |||
"strictPropertyInitialization": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Evaluation Reasons - js-client-sdk-common
Evaluation Reasons - js-client-sdk
Evaluation Reasons - node-server-sdk
Evaluation Reasons - react-native-sdk
This is the main branch for the "Evaluation Reasons" work. Other PRs related to this feature will be merged into this branch before this branch is merged into
main
. This will not be mergeable until other work has been merged into this branch.Implements: FF-2465
Motivation and Context
See Design Doc
Testing
This was manually tested locally with the js-node-sdk as well as with unit tests