feat: Evaluation Details #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This will not pass until we merge and publish |
greghuels
changed the title
greghuels
force-pushed
the
greg/FF-2501/evaluation-reasons-config-time
branch
3 times, most recently
from
b2e41ac to
672e9e6
Compare
This was referenced Jun 26, 2024
aarsilv
approved these changes
Jun 26, 2024
| @@ -56,6 +56,6 @@ | |||
| "webpack-cli": "^4.10.0" | |||
| }, | |||
| "dependencies": { | |||
| "@eppo/js-client-sdk-common": "3.3.3" | |||
| "@eppo/js-client-sdk-common": "4.0.0" | |||
| @@ -30,7 +31,6 @@ import { ServingStoreUpdateStrategy } from './isolatable-hybrid.store'; | |||
| import { | |||
| offlineInit, | |||
| IAssignmentLogger, | |||
| IEppoClient, | |||
greghuels
force-pushed
the
greg/FF-2501/evaluation-reasons-config-time
branch
from
672e9e6 to
6755619
Compare
greghuels
changed the title
greghuels
force-pushed
the
greg/FF-2501/evaluation-reasons-config-time
branch
7 times, most recently
from
e49e815 to
1ff1b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluation Reasons - js-client-sdk-common
Evaluation Reasons - js-client-sdk
Evaluation Reasons - node-server-sdk
Evaluation Reasons - react-native-sdk
Motivation and Context
This implements the "assignment details" functionality for the js-client-sdk.
Description
IEppoClientis being removed in@eppo/js-client-sdk-common@3.4.0, which required updatesIConfigurationStore.setEntriesreturnsPromise<boolean>in@eppo/js-client-sdk-common@3.4.0which also requires updates. Resolving withtrueinternally tells the configuration store to set theconfigFetchedAtandconfigPublishedAtfields.How has this been tested?
Manual testing will be done once @eppo/js-client-sdk-common@3.4.0 is published