Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(events): Bump default batch size to 1k events #125

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

felipecsl
Copy link
Member


labels: mergeable

Fixes: FF-3704

Motivation and Context

Have sane defaults.

Description

As above.

How has this been tested?

N/A

@petzel
Copy link
Contributor

petzel commented Dec 12, 2024

@felipecsl maybe we should also add a minimum, say it can not be less than 100 (or 500) events?

@felipecsl
Copy link
Member Author

@felipecsl maybe we should also add a minimum, say it can not be less than 100 (or 500) events?

good idea, but i'll have to add that validation in the common sdk though!

@felipecsl
Copy link
Member Author

@petzel do you say we just clamp it to our predefined min? so if you pass 10, we set it to 100?

@petzel
Copy link
Contributor

petzel commented Dec 12, 2024

@petzel do you say we just clamp it to our predefined min? so if you pass 10, we set it to 100?

@felipecsl yep that's right

@felipecsl felipecsl merged commit 3db2205 into main Dec 12, 2024
8 checks passed
@felipecsl felipecsl deleted the felipecsl--batch-size-default-bump branch December 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants