Add support for chrome.storage backed configuration store. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
force-pushed
the
lr/ff-2083/chrome-async
branch
from
0316318 to
136ce0b
Compare
leoromanovsky
commented
May 17, 2024
| @@ -83,7 +87,7 @@ export interface IClientConfig { | |||
| export { IAssignmentLogger, IAssignmentEvent, IEppoClient } from '@eppo/js-client-sdk-common'; | |||
|
|
|||
| // Instantiate the configuration store with memory-only implementation. | |||
| const configurationStore = configurationStorageFactory(undefined, true); | |||
| const configurationStore = configurationStorageFactory({ forceMemoryOnly: true }); | |||
There was a problem hiding this comment.
I like this API more - to me it reads more clearly what is being performed.
Comment on lines
+183
to
+184
| chromeStorage: hasChromeStorage() && chrome.storage.local, | ||
| windowLocalStorage: hasWindowLocalStorage() && window.localStorage, |
There was a problem hiding this comment.
IMO not great to have to pass these in with the hasChromeStorage protection but we don't know if the APIs are available otherwise.
sameerank
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Users in the chrome extension environment do not have access to
localStoragebut need to persist configuration between sessions.Description
chrome.storagebackedAsyncStoreHow has this been tested?