Revert client instantiate inside of init
method. Create with empty …
#68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in-memory store. Populate the configuration store in
init
.labels: mergeable
Fixes: #issue
Motivation and Context
Client instantiation was pushed from a static method to the
init
function (b76e8d8)This means that accessing the instance using
EppoClient.getInstance
before callinginit
provided anundefined
variable. Making any API calls against it led to crashes.Description
localStorage
. Now I am changing this to load from an empty memory store. This changes the client behavior so that between getting the client and callinginit
it will always evaluate tonull
.init
method sets the desired configuration store or the factory method detects which environment it is in.How has this been tested?