-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [import apiendpoints and expose url builder] (ff-2310) #85
Merged
sameerank
merged 7 commits into
main
from
sameeran/ff-2310-import-apiendpoints-and-expose-url-builder
Jun 21, 2024
Merged
feat: [import apiendpoints and expose url builder] (ff-2310) #85
sameerank
merged 7 commits into
main
from
sameeran/ff-2310-import-apiendpoints-and-expose-url-builder
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
changed the title
[feat] import apiendpoints and expose url builder (ff-2310)
feat: [import apiendpoints and expose url builder] (ff-2310)
Jun 21, 2024
sameerank
commented
Jun 21, 2024
@@ -59,6 +59,6 @@ | |||
"webpack-cli": "^4.10.0" | |||
}, | |||
"dependencies": { | |||
"@eppo/js-client-sdk-common": "3.3.1" | |||
"@eppo/js-client-sdk-common": "3.3.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leoromanovsky
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
felipecsl
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sameerank
deleted the
sameeran/ff-2310-import-apiendpoints-and-expose-url-builder
branch
June 21, 2024 18:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #issue
Motivation and Context
Description
Exposes a URL builder for the flag config endpoint
Also FYI there are a lot of auto-generated docs that I didn't include in this PR because I noticed that these docs weren't getting updated in the last few PRs, but I can include those files if it's the right thing to do here.
How has this been tested?