Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: getExperimentContainerEntry helper function for CMS app integration #71

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat: getExperimentContainerEntry helper function for CMS app integration #71

merged 1 commit into from
Oct 1, 2024

Conversation

greghuels
Copy link
Contributor

see Eppo-exp/js-sdk-common#123 for motivation and context

@greghuels greghuels requested a review from felipecsl October 1, 2024 16:32
felipecsl
felipecsl approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@felipecsl felipecsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't need the method override?

@greghuels
Copy link
Contributor Author

This one doesn't need the method override?

Nope, that's only on the js-client-sdk

@greghuels greghuels merged commit b96c13d into main Oct 1, 2024
2 checks passed
@greghuels greghuels deleted the greg/common-4.2.0 branch October 1, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecsl felipecsl felipecsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greghuels @felipecsl