Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving missing module #167

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Resolving missing module #167

merged 2 commits into from
Sep 11, 2019

Conversation

vodorok
Copy link
Collaborator

@vodorok vodorok commented Jul 2, 2019

!!!
Bumped minimal required eclipse to 4.8 Photon
!!!

This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0

Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.

Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:

Resolves #164
And depends on #166

@vodorok vodorok requested a review from gyorb July 2, 2019 15:06
@vodorok vodorok force-pushed the new_java_patch branch 15 times, most recently from 0c3f7ca to 1bf4757 Compare July 4, 2019 10:10
@vodorok vodorok mentioned this pull request Jul 4, 2019
@vodorok vodorok force-pushed the new_java_patch branch 5 times, most recently from 2de0845 to 23664a8 Compare July 4, 2019 13:02
@@ -8,9 +8,9 @@ This is a C/C++ code analysis plugin for Eclipse that shows bugs detected by the

* Linux operating system
* Recent [CodeChecker](https://github.com/Ericsson/codechecker) (6.8.0 and up)
* Every eclipse version since [Oxygen 1](https://www.eclipse.org/downloads/packages/release/oxygen/1) (v4.7.0) is supported
* Every eclipse version since [Phtoton](https://www.eclipse.org/downloads/packages/release/photon/r) (v4.8.0) is supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split up the documentation to be more explicit what are the plugin build requirements and what is the runtime requirement for it.

This change mainly effects the build environment if I'm right.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that!
But for the current setup of the compilation, we only test for one target platform, so until we create a deeper matrix with separate, older (newer) target platforms, we can't be sure the plugin works on older releases, even though we won't use newer features. I'll create an issue regarding this problem.
Until then, I can extend the readme with a note that it should work on Oxygen.

</plugin>
</plugins>
</build>
<profiles>
Copy link
Collaborator Author

@vodorok vodorok Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use different configurations depending on the jdk versions. Maven profiles can only alter build segments, that's why this segment got a little bit verbose.

@vodorok
Copy link
Collaborator Author

vodorok commented Jul 24, 2019

Resolves the first part of #132 (update the currently used Tycho version to a newer (latest?)) 1.4.0 is the latest right now.

@vodorok vodorok added the seq 3 label Aug 6, 2019
@vodorok vodorok added seq 2 and removed seq 3 labels Aug 26, 2019
Need to symlink the system CA certificates if necessary.
on openjdk9+.
openjdk9 is allowed to fail because of its fragility.
See more: athttps://www.deps.co/guides/travis-ci-latest-java/
@vodorok vodorok force-pushed the new_java_patch branch 2 times, most recently from 43e3e89 to 9fc78fc Compare September 4, 2019 11:11
@Ericsson Ericsson deleted a comment Sep 4, 2019
@Ericsson Ericsson deleted a comment Sep 4, 2019
@Ericsson Ericsson deleted a comment Sep 4, 2019
@Ericsson Ericsson deleted a comment Sep 4, 2019
This from this eclipse version a newer java support is enabled.
See more at: https://projects.eclipse.org/projects/eclipse/releases/4.8.0

Bumped Tycho to 1.4.0.
Added Javax.annotation bundle to target platform.
Added vmargs to the integration test pom.xml.
Added profiles to jdk 8, 9, 10 & 11.

Fix for the missing dependency with java 11 in the integration test phase.
Referenced in:
* https://wiki.eclipse.org/Tycho/Release_Notes/1.4
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=541403
@Ericsson Ericsson deleted a comment Sep 4, 2019
@Ericsson Ericsson deleted a comment Sep 4, 2019
@vodorok vodorok requested a review from gamesh411 September 5, 2019 10:39
@gamesh411 gamesh411 merged commit 0b5646d into Ericsson:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails
3 participants