Java plugin #557

Wrathan · 2022-02-09T11:56:57Z

No description provided.

… java plugin with rudimentary files.

…a files.

…ible AstNode type.

…itor.

…at the parser modifies only the source of the parser.

…tabase yet.)

…named to "javaparser" in some cases.)

…ameters burned into EMFactory.java.)

…avac compile commands from CodeCompass.

…x a bug, which caused inconsistent parsing state for some files. Failing to parse a node in a file will not cause to stop the whole parsing process for the file.

…d. (Keywords "synchronize" was unnecessary and slowed down the parser.)

…thrown error

intjftw · 2022-05-15T13:16:00Z

@Wrathan Please provide a detailed user guide in doc/usage.md on how to parse Java projects.

intjftw · 2022-05-15T13:27:43Z

plugins/java/parser/include/javaparser/javaparser.h

+  using std::runtime_error::runtime_error;
+};
+
+class JavaParserServiceHandler : public JavaParserServiceIf {


If there is no specific reason for putting multiple large classes into one file, please put this class into a separate header file.

intjftw · 2022-09-28T19:03:08Z

webgui/package.json

-    "marked"           : ">=0.3.6",
+    "marked"           : "2.1.3",


This should be a minimal version, not an exact one.

Especially semantic versioning should be used.

Tilde Version Range (~)
The ~ operator is best explained by example: ~1.2 is equivalent to >=1.2 <2.0.0, while ~1.2.3 is equivalent to >=1.2.3 <1.3.0. As you can see it is mostly useful for projects respecting semantic versioning. A common usage would be to mark the minimum minor version you depend on, like ~1.2 (which allows anything up to, but not including, 2.0). Since in theory there should be no backwards compatibility breaks until 2.0, that works well. Another way of looking at it is that using ~ specifies a minimum version, but allows the last digit specified to go up.

Caret Version Range (^)
The ^ operator behaves very similarly, but it sticks closer to semantic versioning, and will always allow non-breaking updates. For example ^1.2.3 is equivalent to >=1.2.3 <2.0.0 as none of the releases until 2.0 should break backwards compatibility. For pre-1.0 versions it also acts with safety in mind and treats ^0.3 as >=0.3.0 <0.4.0 and ^0.0.3 as >=0.0.3 <0.0.4.
This is the recommended operator for maximum interoperability when writing library code.

intjftw · 2022-09-28T19:11:36Z

plugins/dummy/parser/CMakeLists.txt

-  src/dummyparser.cpp)
+        src/dummyparser.cpp)


This change is unnecessary.

intjftw · 2022-09-28T19:17:25Z

plugins/java/test/src/javaparsertest.cpp

+TEST_F(JavaParserTest, simpleJavaParserTest2)
+{
+  ASSERT_TRUE(true);
+}


Actual tests should be written for the plugin, or this file is unnecessary.

intjftw · 2022-09-28T19:17:34Z

plugins/java/test/src/javaservicetest.cpp

+TEST_F(JavaServiceTest, simpleJavaServiceTest)
+{
+  EXPECT_EQ(7,7);
+}


Actual tests should be written for the plugin, or this file is unnecessary.

intjftw · 2022-09-28T19:17:51Z

plugins/java/test/CMakeLists.txt

+target_link_libraries(javatest ${GTEST_BOTH_LIBRARIES} pthread)
+
+# Add a test to the project to be run by ctest
+add_test(allJavaTest javatest)


Actual tests should be written for the plugin, or this file is unnecessary.

intjftw · 2022-09-28T19:19:03Z

plugins/java/service/src/javaservice.cpp

+  /*
+  std::vector<std::string> content;
+
+  _transaction([&, this]() {
+
+      //--- Load the file content and break it into lines ---//
+
+      model::FilePtr file = _db->query_one<model::File>(
+        FileQuery::id == std::stoull(range_.file));
+
+      if (!file || !file->content.load())
+        return;
+
+      std::istringstream s(file->content->content);
+      std::string line;
+      while (std::getline(s, line))
+        content.push_back(line);
+  });
+
+  javaQueryHandler.getSyntaxHighlight(return_, range_, content);
+  */


Dead code should be deleted.

mcserep · 2024-02-04T08:37:34Z

scripts/CodeCompass_logger

This file should stay executable.

mcserep · 2024-02-04T08:37:47Z

scripts/remover.sh

This file should stay executable.

mcserep · 2024-02-04T08:40:50Z

plugins/dummy/service/src/plugin.cpp

@@ -1,6 +1,6 @@
 #include <webserver/pluginhelper.h>

-#include <service/dummyservice.h>
+#include <service/javaservice.h>


This should not be changed,

mcserep · 2024-02-04T08:40:58Z

plugins/dummy/service/src/javaservice.cpp

@@ -1,4 +1,4 @@
-#include <service/dummyservice.h>
+#include <service/javaservice.h>


This should not be changed,

mcserep · 2024-02-04T08:41:38Z

plugins/dummy/service/CMakeLists.txt

@@ -33,7 +33,7 @@ add_library(dummythrift STATIC
 target_compile_options(dummythrift PUBLIC -fPIC)

 add_library(dummyservice SHARED
-  src/dummyservice.cpp
+        src/javaservice.cpp


This should not be changed,

mcserep · 2024-02-04T08:42:12Z

plugins/dummy/service/include/service/javaservice.h

This should not be renamed, instead the dummyservice should copied as the new javaservice.

intjftw and others added 30 commits November 25, 2020 14:37

Added frame (copied dummy) of Java parser.

43792f1

Create and fill model directory, and fill parser/src directory in the…

334e31e

… java plugin with rudimentary files.

Most database connections created, Entity's structure optimized.

30f57a4

Merge remote-tracking branch 'upstream/master' into java_plugin

3961e95

Rewrite Java specific strings and variable names.

c04c3bf

Merge remote-tracking branch 'upstream/master' into java_plugin

6da5f76

Pulled currently necessary dependencies, and set package info in .jav…

e4f826d

…a files.

Function skeletons to 'visit' functions have been written to all poss…

de3932b

…ible AstNode type.

Java code rearranged to the correct form.

9d08b02

Basics of installing the Java plugin into CodeCompass

d368ea9

CMakeLists files for model.

b3ad1e4

Basics of configuring CMake files for Java plugin.

dbf0bda

Commented unnecessary parts from the service's CMakeList.

5789d9e

Added missing Java dependencies.

aec44b7

Generating files with Thrift for the Java plugin.

8a12fd7

JavaHandler created.

c78306f

JavaHandler's path modified.

91fe93d

Double inclusion fixed.

733883c

C++ and Java files separated.

c59280e

Run javaparser.jar with Boost.

edb302d

Added more dependencies (json.simple and Eclipse dependencies).

713098c

Process compilation database in the Java plugin, and start the ASTVis…

b624d72

…itor.

Argument name corrected.

30b7244

ASTParser object created, when first time a Java file found, after th…

f2b3a00

…at the parser modifies only the source of the parser.

Trying to add xml to javamodel.jar. (Does not work yet)

713cd36

Adding persistence.xml to model jar file.

3b08d29

EntityManager for Persistence created. (Does not connecting to the da…

fde8139

…tabase yet.)

Dummyparser's elements remaned back to dummyparser. (Accidentally, re…

eb39cc8

…named to "javaparser" in some cases.)

EntityManager connect into the postgresql database. (Raw version, par…

ea87076

…ameters burned into EMFactory.java.)

Modified database schema.

2c2d634

Wrathan and others added 18 commits December 2, 2021 06:59

Parse and show Java initializers.

6475340

Parse inner classes correctly and show them in Info Tree.

2b5d300

Fixing minor bugs, modify CMake configuration to generate the right j…

b7b304f

…avac compile commands from CodeCompass.

Implement jar decompiling and parsing. (without classpath yet)

e34ffc0

Parsing classpath for jar parsing from the jar's MANIFEST.MF file. Fi…

a6b151f

…x a bug, which caused inconsistent parsing state for some files. Failing to parse a node in a file will not cause to stop the whole parsing process for the file.

Show inner enums in types, and inner types in enums in Info Tree.

9c6a28d

Group inner types in Info Tree by visibility

c437e10

Make Thrift methods not synchronized to highly increase parser's spee…

5cc687c

…d. (Keywords "synchronize" was unnecessary and slowed down the parser.)

Update log4j version due to a security issue.

db62899

Fixing minor issues to prevent race conditions

853b718

Ignore array type's fields (length field).

edf7be6

Add missing Java dependency

e582634

Minor fixes

7ed1f9b

Bug fix: parsing of variable usages of variables with primitive type …

e10c230

…thrown error

Remove bugfix, because it wont solve the problem

ffdbd2c

Bugfix: Parse array's 'length' property

1bb0f42

Remove runtime information about parsing and decompiling jar files

b2cab25

Adding unzip to dependencies in docker images and GitHub CI.

f5cde28

intjftw requested review from intjftw, mcserep and bruntib February 9, 2022 12:02

intjftw added Kind: Enhancement 🌟 Plugin: Java Issues related to the Java parsing and navigation service. labels Feb 9, 2022

intjftw added this to the Release Gershwin milestone Feb 9, 2022

Introduce new entity hash strategy for generic types.

1d6f0be

intjftw requested changes Sep 28, 2022

View reviewed changes

mcserep force-pushed the master branch from 986d2f3 to fd3edc1 Compare June 9, 2023 12:31

mcserep requested changes Feb 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java plugin #557

Java plugin #557

Wrathan commented Feb 9, 2022

intjftw commented May 15, 2022

intjftw May 15, 2022

intjftw Sep 28, 2022

mcserep Sep 29, 2022

intjftw Sep 28, 2022

intjftw Sep 28, 2022

intjftw Sep 28, 2022

intjftw Sep 28, 2022

intjftw Sep 28, 2022

mcserep Feb 4, 2024

mcserep Feb 4, 2024

mcserep Feb 4, 2024

mcserep Feb 4, 2024

mcserep Feb 4, 2024

mcserep Feb 4, 2024

		@@ -1,4 +1,4 @@
		#include <service/dummyservice.h>
		#include <service/javaservice.h>

Java plugin #557

Are you sure you want to change the base?

Java plugin #557

Conversation

Wrathan commented Feb 9, 2022

intjftw commented May 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment