Skip to content

Commit

Permalink
[clang-tidy][cfg] Remove an alias from the extreme profile
Browse files Browse the repository at this point in the history
It seems like that `bugprone-narrowing-conversions` check is the same as
the `cppcoreguidelines-narrowing-conversions` check.

Check this:
https://github.com/llvm/llvm-project/blob/c63522e6ba7782c335043893ae7cbd37eca24fe5/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp#L136-L137

It seems like both of these checks were included in the `extreme`
profile, thus each of these reports were duplicated basically.

Hereby I'm proposing to keep only one of them in the profile to
workaround this issue.

According to Compiler Explorer https://godbolt.org/z/hvMnqrfEx,
clang-tidy reports these issues only once, with the
`[check,alias,alias...]` schema, thus it does the right thing.
However, PR #3238 introduced a logic that splits these reports
into individual reports.

I'm not sure if that is the right way of dealing with check aliases, but
we definitely need something more robust than including/excluding checks
from profiles.
  • Loading branch information
Balazs Benics committed Mar 4, 2022
1 parent 65f8a50 commit 06e3b3c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion config/labels/analyzers/clang-tidy.json
Original file line number Diff line number Diff line change
Expand Up @@ -4624,7 +4624,6 @@
],
"cppcoreguidelines-narrowing-conversions": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-narrowing-conversions.html",
"profile:extreme",
"severity:MEDIUM"
],
"cppcoreguidelines-no-malloc": [
Expand Down

0 comments on commit 06e3b3c

Please sign in to comment.