Add severity to CodeClimate export

Ericsson · Jun 11, 2021 · 45dfd69 · 45dfd69
1 parent fad91e1
commit 45dfd69
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 5 deletions.
diff --git a/analyzer/codechecker_analyzer/cmd/parse.py b/analyzer/codechecker_analyzer/cmd/parse.py
@@ -638,7 +638,8 @@ def parse_convert_reports(input_dirs: List[str],
 
     number_of_reports = len(all_reports)
     if out_format == "codeclimate":
-        return codeclimate.convert(all_reports), number_of_reports
+        return (codeclimate.convert(all_reports, severity_map),
+                number_of_reports)
 
     if out_format == "gerrit":
         return gerrit.convert(all_reports, severity_map), number_of_reports

diff --git a/analyzer/tests/functional/analyze_and_parse/test_analyze_and_parse.py b/analyzer/tests/functional/analyze_and_parse/test_analyze_and_parse.py
@@ -309,6 +309,7 @@ def test_codeclimate_output(self):
             'description': 'Duplicate code detected',
             'categories': ['Bug Risk'],
             'fingerprint': '3d15184f38c5fa57e479b744fe3f5035',
+            'severity': 'minor',
             'location': {
                 'path': 'notes.cpp',
                 'lines': {

diff --git a/codechecker_common/output/codeclimate.py b/codechecker_common/output/codeclimate.py
@@ -12,7 +12,7 @@
 from codechecker_common.report import Report
 
 
-def convert(reports: List[Report]) -> Dict:
+def convert(reports: List[Report], severity_map: Dict[str, str]) -> Dict:
     """Convert the given reports to codeclimate format.
 
     This function will convert the given report to Code Climate format.
@@ -22,18 +22,30 @@ def convert(reports: List[Report]) -> Dict:
     """
     codeclimate_reports = []
     for report in reports:
-        codeclimate_reports.append(__to_codeclimate(report))
+        codeclimate_reports.append(__to_codeclimate(report, severity_map))
     return codeclimate_reports
 
 
-def __to_codeclimate(report: Report) -> Dict:
+__codeclimate_severity_map = {
+    'CRITICAL': 'critical',
+    'HIGH': 'major',
+    'MEDIUM': 'minor',
+    'LOW': 'minor',
+    'STYLE': 'info',
+    'UNSPECIFIED': 'info',
+}
+
+
+def __to_codeclimate(report: Report, severity_map: Dict[str, str]) -> Dict:
     """Convert a Report to Code Climate format."""
     return {
         "type": "issue",
         "check_name": report.check_name,
         "description": report.description,
         "categories": ["Bug Risk"],
         "fingerprint": report.report_hash,
+        "severity": __codeclimate_severity_map.get(
+            severity_map.get(report.check_name, 'UNSPECIFIED'), 'info'),
         "location": {
             "path": report.file_path,
             "lines": {

diff --git a/web/client/codechecker_client/cmd_line_client.py b/web/client/codechecker_client/cmd_line_client.py
@@ -1228,7 +1228,7 @@ def print_reports(client,
             output_formats.remove('gerrit')
 
         if 'codeclimate' in output_formats:
-            cc_reports = codeclimate.convert(reports)
+            cc_reports = codeclimate.convert(reports, context.severity_map)
             # Codelimate was the only format specified.
             if selected_output_format_num == 1 and not output_dir:
                 print(json.dumps(cc_reports))

diff --git a/web/tests/functional/diff_local_remote/test_diff_local_remote.py b/web/tests/functional/diff_local_remote/test_diff_local_remote.py
@@ -486,6 +486,7 @@ def test_diff_codeclimate_output(self):
                 "Bug Risk"
             ],
             "fingerprint": "c2132f78ef0e01bdb5eacf616048625f",
+            "severity": "minor",
             "location": {
                 "path": "new_delete.cpp",
                 "lines": {