Skip to content

Commit

Permalink
[fix] Minor fixing for statistics tabs
Browse files Browse the repository at this point in the history
The `compare to` filter was turned off for statistics tabs. It is a user request to restore it. Every tabs gets back the filter except checker coverage.

Switching between tabs was problematic. When we want to switch from checker coverage to others tab, it triggers a full page refresh. Now, it is fixed.

The status of the checkere coverage does not show the number of disabled runs for checkers. With this PR, the user can be informed about the number of runs the checker is off and they can also open the disabled runs modal to list them.
  • Loading branch information
cservakt committed Jul 31, 2024
1 parent 0b95256 commit 4d32b4a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion web/server/codechecker_server/api/report_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -3072,7 +3072,7 @@ def getCheckerStatusVerificationDetails(self, run_ids, report_filter):
checkerName=checker_name,
analyzerName=analyzer_name,
enabled=[],
disabled=all_run_id,
disabled=all_run_id.copy(),
severity=severity,
closed=0,
outstanding=0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,6 @@ export default {
async runIds() {
this.noProperRun = false;
},
"$route"() {
if (this.runs && this.$route.query.run !== this.actualRunNames) {
this.$router.go();
}
}
},
Expand Down
4 changes: 3 additions & 1 deletion web/server/vue-cli/src/views/Statistics.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
:show-remove-filtered-reports="false"
:report-count="reportCount"
:show-diff-type="false"
:show-compare-to="false"
:show-compare-to="
$router.currentRoute.name == 'checker-coverage-statistics'
? false : true"
@refresh="refresh"
/>
</pane>
Expand Down

0 comments on commit 4d32b4a

Please sign in to comment.