[gui] Remember filters when navigate between pages #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamesh411
reviewed
Sep 4, 2020
| @@ -1,8 +1,6 @@ | |||
| <template> | |||
| <v-container id="product" fluid> | |||
| <keep-alive> | |||
There was a problem hiding this comment.
Why is keep-alive removed? the router-view must be re-rendered now?
There was a problem hiding this comment.
If you use keep-alive, it will caches the components states. It should be handled properly, when a cached component is showed but something is changed in the URL. It was easier to remove it and initialize it properly when the component is mounted again.
|
I have rebased to master and there is still a "skip not supported yet" error, so cannot verify atm. |
|
Maybe something is stucked. Try to run the |
csordasmarton
force-pushed
the
remember_filters
branch
from
cfdf9d1 to
c01c3bf
Compare
|
Issues
======
- Added 13
Complexity increasing per file
==============================
- web/server/vue-cli/src/store/modules/url.js 2
See the complete overview on Codacy |
gyorb
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.