Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Show selected filter items at Review status filter #2940

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[gui] Show selected filter items at Review status filter #2940

merged 1 commit into from
Oct 30, 2020

Conversation

csordasmarton
Copy link
Contributor

No description provided.

@csordasmarton csordasmarton added this to the release 6.15.0 milestone Sep 14, 2020
@bruntib
Copy link
Contributor

bruntib commented Sep 14, 2020

What does this patch change? I can't see any difference in the GUI.

@csordasmarton
Copy link
Contributor Author

This patch will show the selected review status filter items after the Review status filter label. Similarly to the Detection status filter.
image

@bruntib
Copy link
Contributor

bruntib commented Sep 24, 2020

For some reason it doesn't work for me. Sometimes three dots "..." appear after "Latest Review Status", but I can't see the selected labels 😕

@csordasmarton
Copy link
Contributor Author

@bruntib Maybe the size of the sidebar is too small. Try to increase it and instead of the three dots I think you will see the selected items.

gyorb
gyorb suggested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only the three dots, even resizing the sidebar did not help.
Tested in Firefox 81.0 and Chromium 85.0.4183.121.

It does not change even if I change the filter values and apply them.

@csordasmarton csordasmarton force-pushed the review_status_filter_show_selected_items branch from 36abd17 to dcd569b Compare October 13, 2020 07:40
@csordasmarton csordasmarton requested a review from gyorb October 13, 2020 07:40
@csordasmarton csordasmarton force-pushed the review_status_filter_show_selected_items branch from dcd569b to a79f910 Compare October 29, 2020 13:05
@gyorb
Copy link
Contributor

gyorb commented Oct 29, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy

@csordasmarton csordasmarton merged commit 3843ec9 into Ericsson:master Oct 30, 2020
@csordasmarton csordasmarton deleted the review_status_filter_show_selected_items branch November 6, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyorb gyorb gyorb approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
GUI 🎨
Projects
None yet
Milestone
release 6.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@csordasmarton @bruntib @gyorb