[gui] Expandable runs #2953
[gui] Expandable runs #2953
Conversation
| tagName : t.versionTag, | ||
| title: t.versionTag, | ||
| tagName : t.versionTag ? t.versionTag : t.time, | ||
| title: t.versionTag ? t.versionTag : t.time, |
There was a problem hiding this comment.
You may consider using this more concise syntax:
| title: t.versionTag ? t.versionTag : t.time, | |
| title: t.versionTag || t.time, |
|
|
||
| if run_history_filter and run_history_filter.tagIds: | ||
| query = query.filter(RunHistory.id.in_(run_history_filter.tagIds)) | ||
| if stored.after: |
There was a problem hiding this comment.
stored.before and stored.after are not optional. Are these guaranteed to be 0 by default?
There was a problem hiding this comment.
@bruntib I tried it and the default value will be None if these fields are not set on the client side.
csordasmarton
force-pushed
the
expandable_runs
branch
2 times, most recently
from
5c21fbf to
2bef627
Compare
There was a problem hiding this comment.
Could you extend the history entries with some text to be more explicit about the numbers there.
So the users are not confused what those numbers mean (successful/failed analysis of the source files).
I think some users could think that those numbers are report numbers.
csordasmarton
force-pushed
the
expandable_runs
branch
from
2bef627 to
9b31aca
Compare
|
@gyorb I added a tooltip on these numbers and to this section. I don't really want to add a string explicitly before the analyzer statistics section. By the way if I check a run line I can see that these are analysis statistics, so I can expect that here these are also analyzer statistics. But with my changes if I hover my mouse over this it will shows me this information too. What do you think? |
csordasmarton
force-pushed
the
expandable_runs
branch
from
9b31aca to
bb04706
Compare
|
Issues
======
+ Solved 51
- Added 128
Complexity increasing per file
==============================
- web/server/vue-cli/src/store/modules/run.js 9
- web/server/vue-cli/src/mixins/date.mixin.js 1
See the complete overview on Codacy |
| class="analyzer-statistics" | ||
| :title="'Analysis statistics: shows the number of successfully analyzed' + |
There was a problem hiding this comment.
| :title="'Analysis statistics: shows the number of successfully analyzed' + | |
| :title="'Analysis statistics: shows the number of successfully analyzed ' + |
- Run items can be expanded which will show the run history entries. - Add button to load more run history items.
csordasmarton
force-pushed
the
expandable_runs
branch
from
bb04706 to
7afc78b
Compare
No description provided.