feat(credential_manager): allow users to overwrite location of session file #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargaroff
requested review from
bruntib,
csordasmarton,
dkrupp and
gyorb
as code owners
csordasmarton
added
documentation 📖
csordasmarton
approved these changes
Oct 16, 2020
csordasmarton
suggested changes
Oct 19, 2020
| @@ -21,7 +21,8 @@ | |||
| from codechecker_common.logger import get_logger | |||
| from codechecker_common.util import load_json_or_empty | |||
|
|
|||
| from codechecker_web.shared.env import check_file_owner_rw, get_password_file | |||
| from codechecker_web.shared.env import check_file_owner_rw, get_password_file, \ | |||
There was a problem hiding this comment.
Failed on pycodestyle:
client/codechecker_client/credential_manager.py:24:80: E501 line too long (80 > 79 characters)
There was a problem hiding this comment.
Wasn't aware that the line length was 79, not 80. Thanks for spotting!
Fixed
| CodeChecker. By default CodeChecker will use | ||
| '~/.codechecker.session.json'. This can be used if | ||
| restrictive permissions forbid CodeChecker from creating | ||
| files in the users home directory (e.g. in a CI environment). |
There was a problem hiding this comment.
Failed on pycodestyle:
client/codechecker_client/cmd/store.py:137:80: E501 line too long (80 > 79 characters)
…n file Some CI environments are not allowed to create files outside of their designated workspace. This might include the home directory. This commit allows users to overwrite the hardcoded path and name of the session file by setting the CC_SESSION_FILE environment variable.
|
Issues
======
+ Solved 1
- Added 1
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CI environments are not allowed to create files outside of their
designated workspace. This might include the home directory.
This commit allows users to overwrite the hardcoded path and name of
the session file by setting the CC_SESSION_FILE environment variable.
I didn't know where - if any - to put tests. If required, please tell me what kind of tests you'd like to see and where I should put them. I only tested locally and in our CI environment and it works as expected.