Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less checkers in enable all #3013

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

gyorb
Copy link
Contributor

@gyorb gyorb commented Nov 10, 2020

There is a bugfix and a change in the two commits.
The bugfix is for printing the enabled checkers and the change is to remove more groups from the enable-all configuration.

@gyorb gyorb added bugfix 🔨 analyzer 📈 Related to the analyze commands (analysis driver) labels Nov 10, 2020
@gyorb gyorb added this to the release 6.15.0 milestone Nov 10, 2020
@gyorb gyorb requested a review from dkrupp as a code owner November 10, 2020 09:11
analyzer/codechecker_analyzer/cmd/analyze.py Outdated Show resolved Hide resolved
analyzer/codechecker_analyzer/cmd/check.py Outdated Show resolved Hide resolved
@gyorb gyorb force-pushed the less-checkers-in-enable-all branch from fb54f10 to ec8c894 Compare November 10, 2020 12:47
@gyorb gyorb requested a review from csordasmarton November 10, 2020 12:47
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gyorb gyorb force-pushed the less-checkers-in-enable-all branch from ec8c894 to c05c3ca Compare November 10, 2020 15:15
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyzer related test cases are failed on the travis.

Gyorgy Orban added 2 commits November 11, 2020 11:34
all the checkers were printed not just the enabled before the
starting the analysis
There are too many style checkers executed when the enable-all
flag is used wich causes that a lot of style reports are reported
this change lowers the number of reports when enable-all is used.
The user still can enable those groups if neeeded.
@gyorb gyorb force-pushed the less-checkers-in-enable-all branch from c05c3ca to a7be9e2 Compare November 11, 2020 12:29
@gyorb
Copy link
Contributor Author

gyorb commented Nov 11, 2020

@bruntib do you have any ideas why the number of self.assertEqual(out.count('hicpp-use-nullptr'), 1) results changed during the analyzer tests? Wasn't these numbers changed when the test environment was updated to clang11?

@gyorb gyorb requested a review from csordasmarton November 11, 2020 15:08
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csordasmarton csordasmarton merged commit 682c0bf into Ericsson:master Nov 11, 2020
@gyorb gyorb deleted the less-checkers-in-enable-all branch November 18, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) bugfix 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants