-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Introduce Github action for CodeChecker tests #3066
Conversation
name: codechecker-tests | ||
|
||
# Triggers the workflow on push or pull request events. | ||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there triggers for merging to master master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there is no such option. See: https://gh.neting.ccmunity/t/trigger-workflow-only-on-pull-request-merge/17359/3. It says that on merge event the push event also will be called.
run: | | ||
pip install $(grep -iE "pylint|pycodestyle" analyzer/requirements_py/dev/requirements.txt) | ||
- name: Run tests | ||
run: make pylint pycodestyle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any javascript linters?
d2f6c60
to
832ae87
Compare
ebfe362
to
358c39c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment for #3066 (comment) comment: we run the JavaScript linters in the GUI related job. For this we have to install node and also run the npm install command which takes too much time. In the gui job it is necessary to install these, so this is the reason why I moved GUI linter test to this job and not to the separate linter job.
name: codechecker-tests | ||
|
||
# Triggers the workflow on push or pull request events. | ||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there is no such option. See: https://gh.neting.ccmunity/t/trigger-workflow-only-on-pull-request-merge/17359/3. It says that on merge event the push event also will be called.
a10e9f6
to
4879ce4
Compare
4879ce4
to
c3e0510
Compare
No description provided.