Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Introduce Github action for CodeChecker tests #3066

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

csordasmarton
Copy link
Contributor

No description provided.

@csordasmarton csordasmarton added the test ☑️ Adding or refactoring tests label Nov 30, 2020
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Nov 30, 2020
name: codechecker-tests

# Triggers the workflow on push or pull request events.
on: [push, pull_request]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there triggers for merging to master master branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is no such option. See: https://gh.neting.ccmunity/t/trigger-workflow-only-on-pull-request-merge/17359/3. It says that on merge event the push event also will be called.

run: |
pip install $(grep -iE "pylint|pycodestyle" analyzer/requirements_py/dev/requirements.txt)
- name: Run tests
run: make pylint pycodestyle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any javascript linters?

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@csordasmarton csordasmarton added the WIP 💣 Work In Progress label Dec 2, 2020
@csordasmarton csordasmarton force-pushed the test_github_action branch 8 times, most recently from ebfe362 to 358c39c Compare December 2, 2020 10:31
Copy link
Contributor Author

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment for #3066 (comment) comment: we run the JavaScript linters in the GUI related job. For this we have to install node and also run the npm install command which takes too much time. In the gui job it is necessary to install these, so this is the reason why I moved GUI linter test to this job and not to the separate linter job.

name: codechecker-tests

# Triggers the workflow on push or pull request events.
on: [push, pull_request]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is no such option. See: https://gh.neting.ccmunity/t/trigger-workflow-only-on-pull-request-merge/17359/3. It says that on merge event the push event also will be called.

@csordasmarton csordasmarton force-pushed the test_github_action branch 9 times, most recently from a10e9f6 to 4879ce4 Compare December 2, 2020 11:18
@csordasmarton csordasmarton requested a review from gyorb December 2, 2020 11:59
@csordasmarton csordasmarton removed the WIP 💣 Work In Progress label Dec 2, 2020
@gyorb gyorb merged commit 2094e2c into Ericsson:master Dec 8, 2020
@csordasmarton csordasmarton deleted the test_github_action branch March 10, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 📦 test ☑️ Adding or refactoring tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants