Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Documentation for report identification #3070

Merged

Conversation

csordasmarton
Copy link
Contributor

@csordasmarton csordasmarton commented Dec 1, 2020

Part of #3031

Describe each hash methods in the documentation.

@csordasmarton csordasmarton added the documentation 📖 Changes to documentation. label Dec 1, 2020
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Dec 1, 2020
dkrupp
dkrupp previously requested changes Dec 1, 2020
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the references from the user guide to this document. I even did not know that document existed. I think we should refer to this doc from the user_guide.

Please see my comments in the issue also about the missing intro section of the user guide.

"The user guide should have an intro section explaining and summarizing the Features of the CodeChecker command and its subcommands (each one sentences).

The user guide should also have a separate section on Report hashes, because it is a particularly important topic.
Now it is hidden in the help of the check command
"

Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend with a section with a warning, that the same hash method should be used consistently for a product, mixing them can cause a lot of confusion when the diff or other features are used.

for hash generation to make the hash independent of the
indentation
Unique report identifiers are required to compare analysis results. If an
analyzer (`Clang Static Analyzer`, `Clang Tidy`) do not generate a unique
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
analyzer (`Clang Static Analyzer`, `Clang Tidy`) do not generate a unique
analyzer (`Clang Static Analyzer`, `Clang Tidy`) does not generate a unique

@csordasmarton csordasmarton force-pushed the report_identification_doc branch from a90fa71 to 678c0ec Compare December 10, 2020 08:34
@csordasmarton csordasmarton requested a review from gyorb December 10, 2020 08:34
Describe each hash methods in the documentation.
@csordasmarton csordasmarton force-pushed the report_identification_doc branch from 678c0ec to 15f680f Compare December 10, 2020 08:55
@csordasmarton csordasmarton requested a review from dkrupp December 10, 2020 08:55
@gyorb
Copy link
Contributor

gyorb commented Dec 16, 2020

@dkrupp do you have any further comments to this change?

@csordasmarton csordasmarton dismissed dkrupp’s stale review December 17, 2020 09:52

Comments are fixed.

@csordasmarton csordasmarton merged commit d94c273 into Ericsson:master Dec 17, 2020
@csordasmarton csordasmarton deleted the report_identification_doc branch March 10, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants