Fix LDAP authentication exception #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimis
commented
Dec 3, 2020
gyorb
previously requested changes
Dec 7, 2020
When groupPattern is null in server_config.json, the following
exception was being logged when a user tried to authenticate:
File ".../codechecker_server/auth/cc_ldap.py", line 390, in get_groups
group_pattern = group_pattern.replace('$USERDN$', user_dn)
AttributeError: 'NoneType' object has no attribute 'replace'
groupPattern is also null in one of the examples in authentication.md.
In this case, the get() with default value that was used:
ldap_config.get('groupPattern', '')
actually returned None, since the key actually existed in the dictionary
with value None.
|
@jimis Thank you for this patch and for your time 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus minor logging improvements.