[gui] Handle missing report #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrupp
previously requested changes
Jan 7, 2021
| @@ -111,7 +111,7 @@ | |||
| :to="{ name: 'report-detail', query: { | |||
| ...$router.currentRoute.query, | |||
| 'report-id': item.reportId ? item.reportId : undefined, | |||
| 'report-hash': item.reportId ? undefined : item.bugHash | |||
| 'report-hash': item.bugHash | |||
There was a problem hiding this comment.
Please also add the file name in the url of the reques to show the bug in the correct file in case the report id is missing.
The server will remove reports from the database which have the same report hash on run update. This can cause problem, when the user saves the URL which contains a report id which is actually removed from the database. For this reason we will save the report hash and the file path in the URL and if no report is found with the report id in the database we will falback and search the report by report hash and file path. If the report hash is not in the url or the report can not be found by the report id or report hash we will display this information to the user.
csordasmarton
force-pushed
the
handle_missing_report
branch
from
6734664 to
bb507d3
Compare
bruntib
approved these changes
Jan 7, 2021
This was referenced Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server will remove reports from the database which have the same
report hash on run update. This can cause problem, when the user saves
the URL which contains a report id which is actually removed from
the database.
For this reason we will save the report hash in the URL and if
no report is found with the report id in the database we will falback
and search the report by report hash.
If the report hash is not in the url or the report can not be found
by the report id or report hash we will display this information to
the user.
Screenshot:
