[server] Print API function name in server logs #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current log output of the server outside verbose mode is not useful because everything that is related to CodeChecker is accessed through `/CodeCheckerService`. This patch will log the API function names too in the following format: ``` [INFO 2020-11-24 11:12] - 127.0.0.1:39506 -- [Anonymous] POST /AdjacentParams/v6.35/CodeCheckerService@getReport ```
csordasmarton
force-pushed
the
log_api_function_names
branch
from
d3a1c09 to
8604679
Compare
csordasmarton
changed the title
whisperity
approved these changes
Dec 16, 2020
Comment on lines
+348
to
+350
| cstringio_buf = itrans.cstringio_buf.getvalue() | ||
| itrans = TTransport.TMemoryBuffer(cstringio_buf) | ||
| iprot = input_protocol_factory.getProtocol(itrans) |
There was a problem hiding this comment.
This is needed because previously we started reading when iprot.readMessageBegin() was called, right? I hope this "low-level access" won't backfire magically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current log output of the server outside verbose mode is not useful
because everything that is related to CodeChecker is accessed through
/CodeCheckerService.This patch will log the API function names too in the following format: