[cmd] Do not allow ctu-ast-mode in non-CTU mode #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamesh411
force-pushed
the
ctu-mode-sanity-check
branch
2 times, most recently
from
eee976c to
bfea531
Compare
gamesh411
added
CLI 💻
csordasmarton
suggested changes
Jan 20, 2021
gamesh411
force-pushed
the
ctu-mode-sanity-check
branch
from
bfea531 to
942a627
Compare
csordasmarton
suggested changes
Jan 25, 2021
csordasmarton
suggested changes
Jan 27, 2021
csordasmarton
suggested changes
Jan 28, 2021
csordasmarton
suggested changes
Jan 28, 2021
gamesh411
force-pushed
the
ctu-mode-sanity-check
branch
2 times, most recently
from
7da451c to
b4df1d5
Compare
|
Returned to the old way of checking the arguments, but moved them to the front. Both analyze and check are guarded now. I have also tested this with |
Option ctu-ast-mode is only meaningful if ctu mode is active. Exit early if ctu-ast-mode is specified but ctu mode is not enabled.
* previous patches squashed * removed argparse action solution * move the checking of arg to the beginning of the main function to preceed all other analysis steps * same checking is introduced at the beginning of check's main function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option ctu-ast-mode is only meaningful if ctu mode is active.
Exit early if ctu-ast-mode is specified but ctu mode is not enabled.