[cmd] Handle duplication warning at store #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow it is possible that the store command tries to write the same source file to the zip multiple times. This patch will handle that use case and add a file to the zip if the file is not in there.
csordasmarton
added
CLI 💻
|
Duration of assembling .zip file increased from 3.5 sec to 5.24 sec on Xerces project with this change. This is just a few seconds, so it is not a huge problem. I'm not sure about this ration in case of a bigger project, but if this becomes a real issue, then we should consider normalizing and thus uniqueing paths instead of peeking in the .zip file. |
|
By the way the issue can be reproduced by having the same file with multiple paths in .plist files, e.g.: |
bruntib
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow it is possible that the store command tries to write the same
source file to the zip multiple times. This patch will handle that use
case and add a file to the zip if the file is not in there.