Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Configure keepalive #3167

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

csordasmarton
Copy link
Contributor

When using a CodeChecker server with Docker Swarm on the server side
we may get a [Errno 104] Connection reset by peer exception when for
example the storage takes more than 15 minutes. With the keepalive
parameters we can solve this problem by not destroying the connection
when an operation takes too much time.

Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -759,6 +762,44 @@ def __init__(self,
LOG.error("Couldn't start the server: %s", e.__str__())
raise

def configure_keepalive(self):
""" """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the commit message here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruntib I fixed it.

When using a CodeChecker server with `Docker Swarm` on the server side
we may get a `[Errno 104] Connection reset by peer` exception when for
example the storage takes more than 15 minutes. With the keepalive
parameters we can solve this problem by not destroying the connection
when an operation takes too much time.
@csordasmarton csordasmarton requested a review from bruntib January 28, 2021 08:11
@bruntib bruntib merged commit 9da57ff into Ericsson:master Jan 28, 2021
@csordasmarton csordasmarton deleted the configure_keepalive branch March 10, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants