-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Configure keepalive #3167
Conversation
f49af15
to
ac59f5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -759,6 +762,44 @@ def __init__(self, | |||
LOG.error("Couldn't start the server: %s", e.__str__()) | |||
raise | |||
|
|||
def configure_keepalive(self): | |||
""" """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you put the commit message here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruntib I fixed it.
ac59f5b
to
950b0ac
Compare
When using a CodeChecker server with `Docker Swarm` on the server side we may get a `[Errno 104] Connection reset by peer` exception when for example the storage takes more than 15 minutes. With the keepalive parameters we can solve this problem by not destroying the connection when an operation takes too much time.
950b0ac
to
d915473
Compare
When using a CodeChecker server with
Docker Swarm
on the server sidewe may get a
[Errno 104] Connection reset by peer
exception when forexample the storage takes more than 15 minutes. With the keepalive
parameters we can solve this problem by not destroying the connection
when an operation takes too much time.