Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Close filter settings on apply #3178

Merged
merged 1 commit into from
Feb 15, 2021
Merged

[gui] Close filter settings on apply #3178

merged 1 commit into from
Feb 15, 2021

Conversation

csordasmarton
Copy link
Contributor

Part of #2898

Clicking on Apply button at a filter option should close the options' window.

@csordasmarton
[gui] Close filter settings on apply
b6008c8 
Clicking on `Apply` button at a filter option should close the options' window.
@csordasmarton csordasmarton added GUI 🎨 usability 👍 Usability-related features labels Feb 3, 2021
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Feb 3, 2021
@csordasmarton csordasmarton requested a review from bruntib February 3, 2021 15:03
whisperity
whisperity approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like this.

@bruntib bruntib merged commit f30b58e into Ericsson:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@whisperity whisperity whisperity approved these changes

Assignees
No one assigned
Labels
GUI 🎨 usability 👍 Usability-related features
Projects
None yet
Milestone
release 6.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@csordasmarton @whisperity @bruntib