Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyze] Handle no analyzer use cases #3194

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[analyze] Handle no analyzer use cases #3194

merged 1 commit into from
Mar 2, 2021
+39 −14

Conversation

csordasmarton
Copy link
Contributor

Closes #3141

Handle use cases when no analyzer can be found (clang, clang-tidy) on the user's host machine at all or one of the enabled analyzer is missing.

@csordasmarton csordasmarton added bugfix 🔨 analyzer 📈 Related to the analyze commands (analysis driver) labels Feb 19, 2021
whisperity
whisperity reviewed Feb 19, 2021
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor nit: for open-source users who have the default config json set, I think the error message should mention having your clang(-tidy) binary in the PATH instead of, or before, telling the users to meddle with the config json.

whisperity
whisperity approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. 👍

@csordasmarton
[analyze] Handle no analyzer use cases
188b321 
Handle use cases when no analyzer can be found (clang, clang-tidy) on the
user's host machine at all or one of the enabled analyzer is missing.
@csordasmarton csordasmarton merged commit 56a3fb0 into Ericsson:master Mar 2, 2021
@csordasmarton csordasmarton deleted the handle_no_analyzer branch March 10, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whisperity whisperity whisperity approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
analyzer 📈 Related to the analyze commands (analysis driver) bugfix 🔨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodeChecker cannot execute if there isn't a clang binary on the system
2 participants
@csordasmarton @whisperity