[client] Handle invalid proxy settings

web/client/codechecker_client/helpers/base.py

@@ -9,13 +9,17 @@
 Base Helper class for Thrift api calls.
 """
 
-
+import sys
 from thrift.transport import THttpClient
 from thrift.protocol import TJSONProtocol
 
 from codechecker_client.credential_manager import SESSION_COOKIE_NAME
 from codechecker_client.product import create_product_url
 
+from codechecker_common.logger import get_logger
+
+LOG = get_logger('system')
+
 
 class BaseClientHelper(object):
 
@@ -28,13 +32,43 @@ def __init__(self, protocol, host, port, uri, session_token=None,
         self.__port = port
         url = create_product_url(protocol, host, port, uri)
 
-        self.transport = THttpClient.THttpClient(url)
+        self.transport = None
+
+        try:
+            self.transport = THttpClient.THttpClient(url)
+        except ValueError:
+            # Initalizing THttpClient may raise an exception if proxy settings
+            # are used but the port number is not a valid integer.
+            pass
+        finally:
+            # Thrift do not handle the use case when invalid proxy format is
+            # used (e.g.: no schema is specified). For this reason we need to
+            # verify the proxy format in our side.
+            self._validate_proxy_format()
+
         self.protocol = TJSONProtocol.TJSONProtocol(self.transport)
         self.client = None
 
         self.get_new_token = get_new_token
         self._set_token(session_token)
 
+    def _validate_proxy_format(self):
+        """
+        Validate the proxy settings.
+        If the proxy settings are invalid, it will print an error message and
+        stop the program.
+        """
+        if self.transport and not self.transport.using_proxy():
+            return
+
+        if not self.transport or not self.transport.host or \
+                not isinstance(self.transport.port, int):
+            LOG.error("Invalid proxy format! Check your "
+                      "HTTP_PROXY/HTTPS_PROXY environment variables if "
+                      "these are in the right format: "
+                      "'http[s]://host:port'.")
+            sys.exit(1)
+
     def _set_token(self, session_token):
         """ Set the given token in the transport layer. """
         if not session_token:

web/tests/functional/cmdline/test_cmdline.py

@@ -47,9 +47,9 @@ def setUp(self):
         test_class = self.__class__.__name__
         print('Running ' + test_class + ' tests in ' + test_workspace)
 
-        codechecker_cfg = env.import_test_cfg(test_workspace)[
+        self.codechecker_cfg = env.import_test_cfg(test_workspace)[
             'codechecker_cfg']
-        self.server_url = env.parts_to_url(codechecker_cfg)
+        self.server_url = env.parts_to_url(self.codechecker_cfg)
 
         # Get the test project configuration from the prepared test workspace.
         self._testproject_data = env.setup_test_proj_cfg(test_workspace)
@@ -123,6 +123,28 @@ def test_runs_filter(self):
         self.assertEqual(0, ret)
         self.assertEqual(1, len(json.loads(res)))
 
+    def test_proxy_settings(self):
+        """ Test proxy settings validation. """
+        server_url = f"{self.codechecker_cfg['viewer_host']}:" \
+                     f"{str(self.codechecker_cfg['viewer_port'])}"
+
+        env = self.codechecker_cfg['check_env'].copy()
+        env['HTTP_PROXY'] = server_url
+
+        res_cmd = [self._codechecker_cmd, 'cmd', 'runs',
+                   '--url', str(self.server_url)]
+        ret, _, err = run_cmd(res_cmd, env=env)
+        self.assertEqual(1, ret)
+        self.assertIn("Invalid proxy format", err)
+
+        env['HTTP_PROXY'] = f"http://{server_url}"
+        _, _, err = run_cmd(res_cmd, env=env)
+
+        # We can't check the return code here, because on host machine it will
+        # be zero, but on the GitHub action's job it will be 1 with "Failed to
+        # connect to the server" error message.
+        self.assertNotIn("Invalid proxy format", err)
+
     def test_runs_row(self):
         """ Test cmd row output type. """
         env = self._test_config['codechecker_cfg']['check_env']