[analyze] Fix ccache compiler detection #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try to find compiler binaries from the `PATH` we will resolve the symlinks by using `os.path.realpath` function. If the compiler (`g++/gcc/clang`) is a symlink to `ccache` it will think that the compiler is ccache. When we try to get for example the version of the detected analyze it will return the version for the ccache binary and not for the original compiler. For this reason if the detected compiler binary is `ccache` we will use the original compiler path instead of resolving the symlink.
csordasmarton
added
bugfix 🔨
analyzer 📈
zomen2
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to find compiler binaries from the
PATHwe will resolve thesymlinks by using
os.path.realpathfunction. If the compiler(
g++/gcc/clang) is a symlink toccacheit will think that the compileris ccache. When we try to get for example the version of the detected
analyze it will return the version for the ccache binary and not for
the original compiler.
For this reason if the detected compiler binary is
ccachewe will usethe original compiler path instead of resolving the symlink.