[plist2html] Add type hints #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
test ☑️
zomen2
suggested changes
Mar 4, 2021
| """ | ||
| def twodim_to_table( | ||
| lines: List[List[str]], | ||
| separate_head=True, |
There was a problem hiding this comment.
Suggested change
| separate_head=True, | |
| separate_head: bool =True, |
| def twodim_to_table( | ||
| lines: List[List[str]], | ||
| separate_head=True, | ||
| separate_footer=False |
There was a problem hiding this comment.
Suggested change
| separate_footer=False | |
| separate_footer: bool =False |
| @@ -123,7 +139,7 @@ def __init__(self, layout_dir, severity_map=None): | |||
| self._tag_contents[tag] = get_file_content( | |||
| self._layout_tag_files[tag]) | |||
|
|
|||
| def create(self, output_path, report_data): | |||
| def create(self, output_path: str, report_data): | |||
There was a problem hiding this comment.
What is the type of report_data?
- Add type hints to `plist-to-html` tool. - Add `mypy` static type checker to the requirements - Create new targets to check the code with mypy.
csordasmarton
force-pushed
the
plist_to_html_type_hints
branch
from
0a6bf44 to
1fa63cb
Compare
zomen2
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plist-to-htmltool.mypystatic type checker to the requirements