Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[report-converter][cmd] Parse cpplint Output #3248

Merged
merged 4 commits into from
Apr 6, 2021
Merged

[report-converter][cmd] Parse cpplint Output #3248

merged 4 commits into from
Apr 6, 2021

Conversation

uhziel
Copy link
Contributor

@uhziel uhziel commented Mar 30, 2021

  • cpplint output is parsed and stored into the format:
    file:line:message:checker_name
  • Parser is called from report converter CLI with type 'cpplint'

@uhziel
[report-converter][cmd] Parse cpplint Output
105c041 
- cpplint output is parsed and stored into the format:
   file:line:message:checker_name
- Parser is called from report converter CLI with type 'cpplint'
@uhziel uhziel requested a review from csordasmarton as a code owner March 30, 2021 10:37
@csordasmarton csordasmarton added documentation 📖 Changes to documentation. test ☑️ Adding or refactoring tests tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc. labels Mar 30, 2021
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Mar 30, 2021
csordasmarton
csordasmarton suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thank you very much for your patch 😊 I checked it and it LGTM but I had some small comments. After you fixed it, I think we can merge it.

tools/report-converter/codechecker_report_converter/cpplint/analyzer_result.py Show resolved Hide resolved
tools/report-converter/tests/unit/cpplint_output_test_files/files/sample.cpp Outdated Show resolved Hide resolved
@uhziel uhziel requested review from bruntib and dkrupp as code owners April 6, 2021 04:07
csordasmarton
csordasmarton suggested changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one comment related to the documentation, otherwise LGTM!

tools/report-converter/README.md Outdated Show resolved Hide resolved
@uhziel @csordasmarton
Update tools/report-converter/README.md
07c8321 
Co-authored-by: Márton Csordás <csordasmarton92@gmail.com>
csordasmarton
csordasmarton approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your contribution 😊

@csordasmarton csordasmarton merged commit e0912f5 into Ericsson:master Apr 6, 2021
@uhziel uhziel deleted the report-converter-cpplint branch April 6, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csordasmarton csordasmarton csordasmarton approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

@dkrupp dkrupp Awaiting requested review from dkrupp dkrupp is a code owner

Assignees
No one assigned
Labels
documentation 📖 Changes to documentation. test ☑️ Adding or refactoring tests tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc.
Projects
None yet
Milestone
release 6.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uhziel @csordasmarton