Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Performance test improvement #3278

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[test] Performance test improvement #3278

merged 1 commit into from
Apr 20, 2021

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented Apr 19, 2021

Adding an extra job to performance test: fetching analysis stats.

@bruntib bruntib added enhancement 🌟 test ☑️ Adding or refactoring tests labels Apr 19, 2021
@bruntib bruntib added this to the release 6.16.0 milestone Apr 19, 2021
@csordasmarton
Copy link
Contributor

@bruntib The exit code is changed in #3232 but we forgot to update this script. Can you please update it in a different commit or in a different PR. Also fix the plist error, otherwise this patch LGTM!

@bruntib
[test] Performance test improvement
ef39679 
Adding an extra job to performance test: fetching analysis stats.
@bruntib bruntib force-pushed the performance_test_improvement branch from 95b1542 to ef39679 Compare April 20, 2021 14:25
@bruntib
Copy link
Contributor Author

bruntib commented Apr 20, 2021

@csordasmarton It's a very good catch, thank you!

csordasmarton
csordasmarton approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csordasmarton csordasmarton merged commit 3d77fb8 into Ericsson:master Apr 20, 2021
@bruntib bruntib deleted the performance_test_improvement branch April 22, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomen2 zomen2 zomen2 approved these changes

@csordasmarton csordasmarton csordasmarton approved these changes

@dkrupp dkrupp Awaiting requested review from dkrupp

Assignees
No one assigned
Labels
enhancement 🌟 test ☑️ Adding or refactoring tests
Projects
None yet
Milestone
release 6.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bruntib @csordasmarton @zomen2