Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Fix multiple report dir storage #3281

Merged
merged 4 commits into from
May 5, 2021

Conversation

csordasmarton
Copy link
Contributor

Closes #3273 and closes #3271

@csordasmarton csordasmarton added GUI 🎨 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands test ☑️ Adding or refactoring tests server 🖥️ web 🌍 Related to the web app labels Apr 22, 2021
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Apr 22, 2021
@csordasmarton csordasmarton requested review from dkrupp and bruntib April 22, 2021 13:05
@csordasmarton csordasmarton force-pushed the multiple_report_dir_storage branch 3 times, most recently from 2f99572 to 186ca99 Compare April 26, 2021 08:08
@dkrupp
Copy link
Member

dkrupp commented Apr 26, 2021

Bugs I found during testing
-clang static analyzer name is shown as "unknown" in the report list view

@csordasmarton
Copy link
Contributor Author

@dkrupp For me the analyze name is set properly:
image

The analyze names are set based on the metadata.json file which can be found in each report directories. Please make sure that these files are exist or try to renalyze your project with the --clean option.

@csordasmarton csordasmarton force-pushed the multiple_report_dir_storage branch 3 times, most recently from f54ab32 to ae245a2 Compare April 27, 2021 16:58
Uniqueing analyzer statistics when stored to the server because it is
possible that multiple report directories are stored and both of them
reference the same source file path (e.g.: in both report directories
is failed to analyze this source file).
- Move check command dialog into separate component.
- Highlight options (--enabled, --disabled, --ctu, etc.) in the check commands.
@csordasmarton csordasmarton force-pushed the multiple_report_dir_storage branch from ae245a2 to 8a0956a Compare May 4, 2021 08:45
@dkrupp dkrupp merged commit 69f148a into Ericsson:master May 5, 2021
@csordasmarton csordasmarton deleted the multiple_report_dir_storage branch January 28, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands GUI 🎨 server 🖥️ test ☑️ Adding or refactoring tests web 🌍 Related to the web app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically store report directories recursively Failed file list in the statistics view is incorrect
2 participants