-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Report-Converter Page on readthedocs #3302
Conversation
- Created a new folder tools under docs - Moved readme files of all the tools into respective folder in docs/tools
- Updated the links in the main Readme and User guide
@csordasmarton The tests are failing due to Us shifting the Readme files to the docs folder. Should I modify the tests as tell with the proper path? Also is there a way to run all these tests(8 tests required for merging) locally on my branch? The |
@jay24rajput in this case the github actions are failed on the The problem is that in the tools setup.py file we expect that a readme file can be found beside the setup.py file but now we moved it. So I think we should change the setup.py file. For example: https://github.com/Ericsson/codechecker/blob/master/tools/plist_to_html/setup.py#L5 to this: import os
import setuptools
readme_file_path = os.path.join(
"..", "..", "docs", "tools", "plist_to_html.md")
with open(readme_file_path, "r", encoding="utf-8", errors="ignore") as fh:
long_description = fh.read() I hope that it will work. Also there is no need to move each tool readme to a separate directory under the docs folder. So instead of using this: |
Yes that makes sense, renaming the files with their tool name 👍🏻 I ll change the setup files of each tool accordingly and rename the Readme files |
- Removed nested folders in tools folder - Renamed Readmes with the folder name
- Changed links to readme likes in the main Readme and supported code analyzer
- Setup files for all tool to accept the path of the modified readme files
@csordasmarton Any idea as to why that one test case is failing cause it passed for the previous commit? Maybe those changes are required in the package.json and package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jay24rajput The github action failure was a virtual machine / network problem and not related to your changes. I restarted the action and now it is passed.
Shifted the Readme files from the
tools
directory into thedocs/tools
directoryFixes #3241