Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode GCC in build-logger Makefile #3352

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Don't hardcode GCC in build-logger Makefile #3352

merged 1 commit into from
Jun 11, 2021
+1 −1

Conversation

LebedevRI
Copy link
Contributor

There may not be a gcc program, and CC may be pointing
at the right one, but this would completely override it,
failing the build.

@LebedevRI
Don't hardcode GCC in build-logger Makefile
12d9cdf 
There may not be a `gcc` program, and `CC` may be pointing
at the right one, but this would completely override it,
failing the build.
@LebedevRI LebedevRI requested a review from bruntib as a code owner June 10, 2021 17:14
@csordasmarton csordasmarton added tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc. tu_collector 📃 The TU-collector analysis crash helper tool labels Jun 11, 2021
@csordasmarton csordasmarton added this to the release 6.17.0 milestone Jun 11, 2021
csordasmarton
csordasmarton approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this patch 😊

@csordasmarton csordasmarton merged commit eec3ed2 into Ericsson:master Jun 11, 2021
@LebedevRI LebedevRI deleted the dont-hardcode-gcc branch June 11, 2021 11:52
@LebedevRI
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csordasmarton csordasmarton csordasmarton approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc. tu_collector 📃 The TU-collector analysis crash helper tool
Projects
None yet
Milestone
release 6.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LebedevRI @csordasmarton