[gui] Fix exporting checker statistics to CSV #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zomen2
reviewed
Jun 23, 2021
| .join("") | ||
| // Hashmark (#) is a valid URL character but it starts the hash | ||
| // fragment and for this reason it needs to be escaped. | ||
| .replace("#", encodeURIComponent("#")); |
There was a problem hiding this comment.
The pattern in this function call is a "string" instead of a "regex", so the first occurrence will be replaced only.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
Other note: encodeURIComponent("#") could be stored in a variable which provides that only one call will be done of this function.
There was a problem hiding this comment.
Yes, good catch. I change it to replaceAll so it will replace every occurances of hashmarks.
This is not frequently used function and encoding hashmark is not a slow operation, so I don't think it worth to move it into a separate variable.
It is possible that a checker name contains a hashmark character (`clang-diagnostic-#warnings`, `clang-diagnostic-#pragma-messages`). Hashmark is a valid URL character but it starts the hash fragment and for this reason it needs to be escaped when we export the statistics to CSV.
csordasmarton
force-pushed
the
fix_checker_statistics_export
branch
from
9fd5f78 to
cc0aaab
Compare
zomen2
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that a checker name contains a hashmark character
(
clang-diagnostic-#warnings,clang-diagnostic-#pragma-messages).Hashmark is a valid URL character but it starts the hash fragment and
for this reason it needs to be escaped when we export the statistics
to CSV.