Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[report-converter] LeakSanitizer Parser #3368

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

jay24rajput
Copy link
Contributor

@jay24rajput jay24rajput commented Jun 28, 2021

Summary:

LeakSanitizer report converter tool for parsing LeakSanitizer output

Progress

  • Implementation
  • Test Case
  • Documentation

Fixes #3321

@whisperity whisperity added report-converter 🔄 tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc. labels Jul 5, 2021
- LeakSanitizer output is parsed and stored
- Parser is called from report converter CLI with type 'lsan'
- LeakSanitizer is tested with lsan.out
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one more tiny little comment, otherwise it's LGTM. Once this comment is fixed we can merge it. Thank you 😊

docs/tools/report-converter.md Show resolved Hide resolved
- Leak Sanitizer documentation in report converter explains the usage
  of lsan tool on any c file
- Enabled leak sanitizer in supported code analyzers
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this patch 👍

@csordasmarton csordasmarton merged commit b5127da into Ericsson:master Jul 7, 2021
ASAN_OPTIONS=detect_leaks=1 ./a.out > lsan.output 2>&1

# Generate plist files from the output.
report-converter -t lsan ./lsan_results lsan.output

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost a "-o" option before "./lsan_results"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Let me fix that in a pull request!

Thanks for pointing it out 😄

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are welcome, and in addition , could you please help me to check issue #3373 if you have extra time,
I compiled the newest code this morning ,but I can not convert lsan report, even use the official leak sanitizer output, I am really confused now , I don't know which of my steps is wrong or maybe I lost something😥.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report-converter 🔄 tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LeakSanitizer support in report-converter
4 participants