-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[report-converter] LeakSanitizer Parser #3368
Conversation
tools/report-converter/tests/unit/lsan_output_test_files/lsan.out
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/sanitizers/leak/output_parser.py
Outdated
Show resolved
Hide resolved
- LeakSanitizer output is parsed and stored - Parser is called from report converter CLI with type 'lsan'
- LeakSanitizer is tested with lsan.out
67b14ea
to
1311357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one more tiny little comment, otherwise it's LGTM. Once this comment is fixed we can merge it. Thank you 😊
- Leak Sanitizer documentation in report converter explains the usage of lsan tool on any c file - Enabled leak sanitizer in supported code analyzers
4e1c032
to
a4f3b28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for this patch 👍
ASAN_OPTIONS=detect_leaks=1 ./a.out > lsan.output 2>&1 | ||
|
||
# Generate plist files from the output. | ||
report-converter -t lsan ./lsan_results lsan.output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lost a "-o" option before "./lsan_results"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Let me fix that in a pull request!
Thanks for pointing it out 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are welcome, and in addition , could you please help me to check issue #3373 if you have extra time,
I compiled the newest code this morning ,but I can not convert lsan report, even use the official leak sanitizer output, I am really confused now , I don't know which of my steps is wrong or maybe I lost something😥.
Summary:
LeakSanitizer report converter tool for parsing LeakSanitizer output
Progress
Fixes #3321