Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Fix gerrit output #3378

Merged
merged 1 commit into from
Jul 14, 2021
Merged

[cli] Fix gerrit output #3378

merged 1 commit into from
Jul 14, 2021

Conversation

csordasmarton
Copy link
Contributor

  • Use source line in the gerrit output instead of the line number at the end of the report message.
  • If a report not found in the changed files list, add report to the main message.

@csordasmarton csordasmarton added bugfix 🔨 test ☑️ Adding or refactoring tests labels Jul 12, 2021
@csordasmarton csordasmarton added this to the release 6.17.0 milestone Jul 12, 2021
@csordasmarton csordasmarton requested review from bruntib and zomen2 July 12, 2021 12:20
@csordasmarton
[cli] Fix gerrit output
d48c4e1 
- Use source line in the gerrit output instead of the line number at the
end of the report message.
- If a report not found in the changed files list, add report to the main
message.
@csordasmarton csordasmarton merged commit 5e57931 into Ericsson:master Jul 14, 2021
@csordasmarton csordasmarton deleted the fix_gerrit_output branch January 28, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomen2 zomen2 zomen2 approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
bugfix 🔨 test ☑️ Adding or refactoring tests
Projects
None yet
Milestone
release 6.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@csordasmarton @zomen2