Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Local diff workflow support #3388

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

csordasmarton
Copy link
Contributor

@csordasmarton csordasmarton commented Aug 4, 2021

Closes #3272

  • Extend the CodeChecker parse command with an extra baseline output type
    which can be used to generate a baseline file which will contain
    report hashes for legacy reports.
  • Extend the CodeChecker cmd diff to support baseline files.
  • Add test cases.
  • Extend the documentation with the recommended usage of this workflow.

@csordasmarton csordasmarton added enhancement 🌟 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands test ☑️ Adding or refactoring tests documentation 📖 Changes to documentation. labels Aug 4, 2021
@csordasmarton csordasmarton added this to the release 6.17.0 milestone Aug 4, 2021
@csordasmarton csordasmarton requested review from dkrupp and bruntib August 4, 2021 12:52
@csordasmarton csordasmarton force-pushed the local_diff_workflow branch 2 times, most recently from 1de0ede to 9ad51ed Compare August 4, 2021 12:57
@csordasmarton csordasmarton requested a review from vodorok August 6, 2021 08:12
@csordasmarton csordasmarton force-pushed the local_diff_workflow branch 2 times, most recently from 6675896 to 8e815cd Compare August 9, 2021 13:44
analyzer/codechecker_analyzer/cmd/parse.py Outdated Show resolved Hide resolved
codechecker_common/output/baseline.py Outdated Show resolved Hide resolved
codechecker_common/output/baseline.py Outdated Show resolved Hide resolved
codechecker_common/output/baseline.py Outdated Show resolved Hide resolved
codechecker_common/output/baseline.py Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
web/client/codechecker_client/cmd_line_client.py Outdated Show resolved Hide resolved
web/client/codechecker_client/cmd_line_client.py Outdated Show resolved Hide resolved
web/client/codechecker_client/cmd_line_client.py Outdated Show resolved Hide resolved
@csordasmarton csordasmarton force-pushed the local_diff_workflow branch 3 times, most recently from ffb06d4 to 31472dd Compare August 12, 2021 09:34
@csordasmarton csordasmarton requested a review from bruntib August 12, 2021 09:45
Copy link
Contributor

@bruntib bruntib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments, but apart from those it looks good to me.

analyzer/codechecker_analyzer/cmd/parse.py Outdated Show resolved Hide resolved
Comment on lines 842 to 841
# The HTML part will be handled separately below.
if export != 'html':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# The HTML part will be handled separately below.
if export != 'html':
if export == 'json':

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true, because this branch handles the following export types: 'json', 'codeclimate', 'gerrit'

docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
- Extend the `CodeChecker parse` command with an extra baseline output type
which can be used to generate a baseline file which will contain
report hashes for legacy reports.
- Extend the `CodeChecker cmd diff` to support baseline files.
- Add test cases.
- Extend the documentation with the recommended usage of this workflow.
@bruntib bruntib merged commit 8172976 into Ericsson:master Aug 17, 2021
@csordasmarton csordasmarton deleted the local_diff_workflow branch January 28, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands documentation 📖 Changes to documentation. enhancement 🌟 test ☑️ Adding or refactoring tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeChecker local diff workflow
2 participants