-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Local diff workflow support #3388
Conversation
1de0ede
to
9ad51ed
Compare
6675896
to
8e815cd
Compare
ffb06d4
to
31472dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor comments, but apart from those it looks good to me.
# The HTML part will be handled separately below. | ||
if export != 'html': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# The HTML part will be handled separately below. | |
if export != 'html': | |
if export == 'json': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true, because this branch handles the following export types: 'json', 'codeclimate', 'gerrit'
- Extend the `CodeChecker parse` command with an extra baseline output type which can be used to generate a baseline file which will contain report hashes for legacy reports. - Extend the `CodeChecker cmd diff` to support baseline files. - Add test cases. - Extend the documentation with the recommended usage of this workflow.
31472dd
to
51b2780
Compare
CodeChecker parse
command with an extra baseline output typewhich can be used to generate a baseline file which will contain
report hashes for legacy reports.
CodeChecker cmd diff
to support baseline files.