Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Add 'thrift==0.13.0' dependency explicitly #3389

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

whisperity
Copy link
Contributor

Fixes #3387.

Hopefully this will fix the generated PyPI package missing this dependency and thus not working in a clean venv.

Hopefully this will fix the generated PyPI package missing this
dependency and thus not working in a clean venv.
@whisperity whisperity added bugfix 🔨 web 🌍 Related to the web app dependencies 📦 Pull requests that update a dependency file labels Aug 5, 2021
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csordasmarton csordasmarton merged commit 064200a into Ericsson:master Aug 6, 2021
@csordasmarton csordasmarton added this to the release 6.17.0 milestone Sep 6, 2021
@whisperity whisperity deleted the thrift-dependency branch April 11, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔨 dependencies 📦 Pull requests that update a dependency file web 🌍 Related to the web app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency in PyPi package
2 participants