Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Override argparse error code #3408

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

csordasmarton
Copy link
Contributor

Closes #3406

By default argparse will exit with error code 2 in case of error, but
we are using this error code for different purposes. For this reason
we will override the ArgumentParser class, so we will exit with error
code 1 in such cases too to identify a CodeChecker error.

By default argparse will exit with error code 2 in case of error, but
we are using this error code for different purposes. For this reason
we will override the ArgumentParser class, so we will exit with error
code 1 in such cases too to identify a CodeChecker error.
@csordasmarton csordasmarton added CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands bugfix 🔨 test ☑️ Adding or refactoring tests labels Aug 25, 2021
@csordasmarton csordasmarton added this to the release 6.17.0 milestone Aug 25, 2021
@csordasmarton csordasmarton requested a review from bruntib August 25, 2021 09:15
@bruntib bruntib merged commit 2144a7f into Ericsson:master Aug 26, 2021
@csordasmarton csordasmarton deleted the override_argparse_error_code branch January 28, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔨 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands test ☑️ Adding or refactoring tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error code for unrecognized arguments
2 participants