[cfg] Add 'bugprone-suspicious-memory-comparison' to config #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checker landed recently in `3373e845398bfb8fa0e3c81b7ca84cbfedbad3ae` [1], and covers SEI-CERT rules **EXP42-C** [2] and **FLP37-C** [3] in the same implementation. SEI-CERT classifies **EXP42-C** as Medium severity with Probable likelihood, while **FLP37-C** is of Low severity and Unlikely likelihood. Due to the fix of the issue being minimal engineering effort (making a comparison predicate and replacing uses of `(std::)memcmp` with it), the `MEDIUM` severity in our case I believe is justified. [1]: http://github.com/llvm/llvm-project/commit/3373e845398bfb8fa0e3c81b7ca84cbfedbad3ae [2]: http://wiki.sei.cmu.edu/confluence/display/c/EXP42-C.+Do+not+compare+padding+data [3]: http://wiki.sei.cmu.edu/confluence/display/c/FLP37-C.+Do+not+use+object+representations+to+compare+floating-point+values
whisperity
added
analyzer 📈
|
+1 |
|
Checker configuration is changed in #3233. Can you please rebase your branch and resolve the merge conflict. The new configuration files can be found here: https://github.com/Ericsson/codechecker/tree/master/config/labels. |
|
I close this ticket and transfer the changed to the other format: #3413. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checker landed recently in
3373e845398bfb8fa0e3c81b7ca84cbfedbad3ae1,and covers SEI-CERT rules EXP42-C 2 and FLP37-C 3 in the same
implementation.
SEI-CERT classifies EXP42-C as Medium severity with Probable likelihood,
while FLP37-C is of Low severity and Unlikely likelihood.
Due to the fix of the issue being minimal engineering effort (making a
comparison predicate and replacing uses of
(std::)memcmpwith it), theMEDIUMseverity in our case I believe is justified.CC: @steakhal