[analyser] Build log transformer: also ignore -fno-reorder-functions #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
added
analyzer 📈
whisperity
force-pushed
the
freorder-functions
branch
from
6093796 to
5b4248e
Compare
|
Okay, so all these flags have "positive" and "negative" versions. |
I am not 100% sure if all have a negative version. We should double check this. And if that is really the case then we could create a new PR for generalizing -ffeature and -fno-feautre. |
martong
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is unknown by Clang (the review for introducing it back from 2017 is here: http://reviews.llvm.org/D34796). The "positive" version has been part of our rewriting logic for a while now, but there is also a negative version of the flag that also results in "unknown flag" errors in Clang.