[analyzer] Don't run ClangSA checkers from clang-tidy #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
bugfix 🔨
analyzer 📈
csordasmarton
suggested changes
Sep 1, 2021
bruntib
force-pushed
the
no_clangsa_from_tidy
branch
from
48f3e91 to
e9a08e6
Compare
csordasmarton
suggested changes
Sep 2, 2021
bruntib
force-pushed
the
no_clangsa_from_tidy
branch
from
e9a08e6 to
245658f
Compare
bruntib
force-pushed
the
no_clangsa_from_tidy
branch
from
245658f to
903fa72
Compare
`clang-tidy` can invoke some ClangSA checkers. We are disabling this behavior by default, because ClangSA checkers should run through ClangSA itself. We missed this disable if analyzer config options were given to clang-tidy. If ClangSA has some bug then it would effect clang-tidy analysis too. That's the real reason why we force disabling.
bruntib
force-pushed
the
no_clangsa_from_tidy
branch
from
903fa72 to
a7cab42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidycan invoke some ClangSA checkers. We are disabling thisbehavior by default, because ClangSA checkers should run through ClangSA
itself. We missed this disable if analyzer config options were given to
clang-tidy. If ClangSA has some bug then it would effect clang-tidy
analysis too. That's the real reason why we force disabling.