Cleanup plans #3419
Cleanup plans #3419
Conversation
csordasmarton
added
enhancement 🌟
API change 📄
csordasmarton
force-pushed
the
cleanup_plans
branch
4 times, most recently
from
c913701 to
2220d66
Compare
| throws (1: codechecker_api_shared.RequestFailed requestError), | ||
|
|
||
| // Add a new cleanup plan or manage an existing one. | ||
| // PERMISSION: PRODUCT_ADMIN |
There was a problem hiding this comment.
Is it a conceptual thing that only admins can add new cleanup plans? Is it intentional that we don't want to bind it to PRODUCT_STORE?
There was a problem hiding this comment.
For now it will work the same way as source components, so only admins will be allowed to manage cleanup plans.
|
|
||
| cleanup_plan_name = Column( | ||
| Integer, | ||
| ForeignKey('cleanup_plans.name', |
There was a problem hiding this comment.
Is it worth using a string as primary key? I mean using this column as foreign key for joining a table may unnecessarily increase database size. Probably this is not a huge date compared to other tables, still this could be some easy save.
There was a problem hiding this comment.
I changed the database schema to use an id primary column. I also refactored the API functions to use id instead of name parameter.
csordasmarton
force-pushed
the
cleanup_plans
branch
3 times, most recently
from
c74d907 to
ec66c39
Compare
- Manage cleanup plans (create, edit, remove, close, reopen). - Assign reports to cleanup plans. - Filter reports by cleanup plans. - Add functional and e2e test cases.
csordasmarton
force-pushed
the
cleanup_plans
branch
from
ec66c39 to
509f05e
Compare
Screenshots:
