[analyzer] Use -imacros flag instead of -macros

[whisperity]

This was seemingly last touched in #2449 (7d93b32) but it seems like a typo. There's no such flag as -macros in neither Clang nor GCC.

via @steakhal

[csordasmarton]

LGTM!

[bruntib]

I wouldn't be so brave to do this modification in the last minute before the release. It is possible that we met this flag in a non-standard compiler. If the addition of -imacros is needed, then add it instead of change the previous one.

[whisperity]

If the addition of -imacros is needed, then add it instead of change the previous one.

@bruntib Yeah that's why I wanted you to look at the patch too... I couldn't figure out the reasoning behind the changes in the previous patch.

The addition of -imacros is definitely needed, the patch is coming from field experience with a user whose build broke specifically because of this argument (their build system used it like 3 times) was torn out from the analysis invocation.

I'll change the patch ASAP!

[csordasmarton]

I think it was a typo during code refactoring when this macros flag was skipped instead of imacros in the following commit: 1a58634

Previous imacros was used:

[steakhal]

I think it was a typo during code refactoring when this macros flag was skipped instead of imacros in the following commit: 1a58634

Previous imacros was used:

This seems like a clear indication of a typo. IMO the patch is good as-is.

[whisperity]

(Side note: we should really put some comments up what these big lists of flags mean.)

I have the updated patch ready if you want that, but I am fine with keeping the current patch.

[steakhal]

I guess this missed the 6.17.0 release.

[whisperity]

I guess this missed the 6.17.0 release.

@steakhal Yeah, seems like so, I just asked. We could target both 6.17.1 and 6.18 though.