[cli][server] Refactoring code for sarif support #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
CLI 💻
csordasmarton
force-pushed
the
sarif_support
branch
9 times, most recently
from
474c01b to
2cda6af
Compare
csordasmarton
force-pushed
the
sarif_support
branch
5 times, most recently
from
2c42211 to
ce8c401
Compare
bruntib
requested changes
Nov 4, 2021
tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py
Outdated
Show resolved
Hide resolved
csordasmarton
force-pushed
the
sarif_support
branch
from
ce8c401 to
8fdb37d
Compare
The basic idea behind these changes is that in this patch we created a general `Report` class which holds information about bugs what are needed by the CodeChecker CLI and server. We introduced helper functions in this patch to convert analyzer result files (for now only plist) to Report objects. All the converters (html, gerrit, codeclimate, json, etc.) and report hash generation modules will work on these Report objects. This patch also tried to remove duplication between the different command line subcommands (parse, diff, store etc.).
csordasmarton
force-pushed
the
sarif_support
branch
from
8fdb37d to
90eafcd
Compare
bruntib
approved these changes
Nov 5, 2021
extract
added a commit
to extract/codechecker
that referenced
this pull request
Nov 19, 2021
After commit Ericsson#3462 the links in the README.md broke in the Common Tools section. This commit removes those links as they seem to no longer be necessary. @csordasmarton
|
The json output of the Yes, it's our mistake that we forgot to mention it in the release notes. So sorry for that :/ |
csordasmarton
added
the
WARN ⚠️: Backward compatibility breaker!
csordasmarton
added a commit
to csordasmarton/codechecker
that referenced
this pull request
Jan 11, 2022
In the `6.18.0` release Ericsson#3462 patch introduced a bug that not all of the control points are stored to the server, because the plist format what the report converter produced and the plist parser expected was invalid: - `range` key was used instead of `ranges`. - Control events are not stored as separated items but as a single control event.
csordasmarton
added a commit
that referenced
this pull request
Jan 12, 2022
In the `6.18.0` release #3462 patch introduced a bug that not all of the control points are stored to the server, because the plist format what the report converter produced and the plist parser expected was invalid: - `range` key was used instead of `ranges`. - Control events are not stored as separated items but as a single control event.
steakhal
pushed a commit
to steakhal/codechecker
that referenced
this pull request
Jan 15, 2022
In the `6.18.0` release Ericsson#3462 patch introduced a bug that not all of the control points are stored to the server, because the plist format what the report converter produced and the plist parser expected was invalid: - `range` key was used instead of `ranges`. - Control events are not stored as separated items but as a single control event.
extract
added a commit
to extract/codechecker
that referenced
this pull request
Aug 17, 2022
After commit Ericsson#3462 the links in the README.md broke in the Common Tools section. This commit changes those to the correct link.
bruntib
pushed a commit
that referenced
this pull request
Aug 17, 2022
[doc] fix dead links in README.md After commit #3462 the links in the README.md broke in the Common Tools section. This commit fixes those links as they seem to be moved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea behind these changes is that in this patch we created a
general
Reportclass which holds information about bugs what are neededby the CodeChecker CLI and server. We introduced helper functions in this patch
to convert analyzer result files (for now only plist) to Report objects.
All the converters (html, gerrit, codeclimate, json, etc.) and report hash
generation modules will work on these Report objects.
This patch also tried to remove duplication between the different command
line subcommands (parse, diff, store etc.).